[TRAFODION-2802] fix this problem #1296
Conversation
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Thanks for contributing this script. It will, however, fail the static checks, since it does not have an Apache license header. Also, don't some of these tool dependencies duplicate things in traf_setup_tools script? Maybe one script could call the other? |
|
jenkins, ok to test |
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2174/ |
|
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/2174/ |
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2175/ |
|
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/2175/ |
|
jenkins, retest |
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2185/ |
|
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/2185/ |
| @@ -0,0 +1,186 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
This file needs an Apache license header. (This is why the static checks are failing.)
| default local software directory is [${MY_LOCAL_SW_DIST}]. You | ||
| can set environment MY_LOCAL_SW_DIST to change it." | ||
| echo "Do you want continue? Enter y/n (default:n):" | ||
| read YN |
There was a problem hiding this comment.
Suggested wordsmithing: "WARNING: Local software tools aren't present. Will download all tools from the internet. This will be very slow. If you do have the local software tools present, set the environment variable MY_LOCAL_SW_DIST to point to them and run this script again. The default local software directory is [${MY_LOCAL_SW_DIST}]. Do you want to continue? Enter y/n (default: n):"
| Y|y|Yes|YES) | ||
| ;; | ||
| *) | ||
| echo "Download following build tools from internet:" |
There was a problem hiding this comment.
Suggested wordsmith: "Downloading the following build tools from the internet:"
| do | ||
| local_file=`ls ${MY_LOCAL_SW_DIST} | grep ${local_sw}` | ||
| if [ "x${local_file}" = "x" ]; then | ||
| echo "WARN: [${local_sw}] source file not exist in directory [${MY_LOCAL_SW_DIST}]" |
There was a problem hiding this comment.
Suggested wordsmith: "WARNING: [${local_sw}] source file does not exist in directory [${MY_LOCAL_SW_DIST}]"
| if [ "x$?" != "x0" ]; then | ||
| case ${basecmd} in | ||
| yum) | ||
| echo "ERROR: yum must install first by yourself." |
There was a problem hiding this comment.
Do you mean, "ERROR: You must first install yum"?
| fi | ||
| ;; | ||
| *) | ||
| echo "ERROR: command [${basecmd}] not exist, make sure you have installed,and the path command added to path rightly." |
There was a problem hiding this comment.
Suggest: "ERROR: command [${basecmd}] does not exist. Make sure you have installed it, and have added it to the command path."
| echo "INFO: os distributor id is [${osdistributor}]" | ||
| ;; | ||
| *) | ||
| echo "ERROR: os distributor is [${osdistributor}], but only support RedHat or CentOS now." |
There was a problem hiding this comment.
Suggest: "ERROR: The OS distribution is [${osdistributor}], but Trafodion only supports RedHat and CentOS presently."
| echo "INFO: os version is [$osver]" | ||
| ;; | ||
| *) | ||
| echo "ERROR: os version is [$osver], but only support 6.x now." |
There was a problem hiding this comment.
Suggest: "ERROR: OS version is [$osver]. Only 6.x versions are presently supported."
|
Can you please update the title of the PR with the JIRA heading at least. |
No description provided.