Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

TRAFODION-2823 some test case donot close connection #1320

Merged
merged 3 commits into from
Dec 18, 2017

Conversation

gpj1987
Copy link
Contributor

@gpj1987 gpj1987 commented Nov 30, 2017

some classes in incubator-trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test do not close statement and connection, which will lead to no connection can be use.
classes include :
PropTest.java
TestNetworkTimeout.java
TestWrap.java

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2213/

@Traf-Jenkins
Copy link

Copy link
Contributor

@DaveBirdsall DaveBirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test builds are failing.

} catch (SQLException e) {
if (conn !=null) {
conn.close();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jenkins builds are complaining that this code has an uncaught exception of some sort. Could you take a look? Thanks.

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2235/

@Traf-Jenkins
Copy link

@Traf-Jenkins
Copy link

Previous Test Aborted. New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2236/

@Traf-Jenkins
Copy link

@selvaganesang
Copy link
Contributor

jenkins, retest

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2251/

@Traf-Jenkins
Copy link

@DaveBirdsall
Copy link
Contributor

The JDBC test suite is failing with a compilation error:

2017-12-13 19:11:08 [ERROR] /home/jenkins/workspace/jdbc_test-cdh/trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test/TestNetworkTimeout.java:[75,36] error: not a statement
2017-12-13 19:11:08 [ERROR] /home/jenkins/workspace/jdbc_test-cdh/trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test/TestNetworkTimeout.java:[75,37] error: ';' expected

Please fix and we'll try again.

Copy link
Contributor

@DaveBirdsall DaveBirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there was a typo in the fix

@@ -64,10 +72,19 @@ public void testGetNetworkTimeout() {
Connection conn = null;
try {
System.out.println("Connecting to database...");
conn = Utils.getUserConnection();
conn = Utils.getUserConnection();S
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra "S" at the end of the line appears to be causing the JDBC build failure

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2260/

@Traf-Jenkins
Copy link

Copy link
Contributor

@DaveBirdsall DaveBirdsall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Looks good to me

@asfgit asfgit merged commit 0bb625b into apache:master Dec 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants