-
Notifications
You must be signed in to change notification settings - Fork 154
TRAFODION-2823 some test case donot close connection #1320
Conversation
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2213/ |
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/2213/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test builds are failing.
} catch (SQLException e) { | ||
if (conn !=null) { | ||
conn.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Jenkins builds are complaining that this code has an uncaught exception of some sort. Could you take a look? Thanks.
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2235/ |
47e5775
to
d795029
Compare
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/2235/ |
Previous Test Aborted. New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2236/ |
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/2236/ |
jenkins, retest |
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2251/ |
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/2251/ |
The JDBC test suite is failing with a compilation error: 2017-12-13 19:11:08 [ERROR] /home/jenkins/workspace/jdbc_test-cdh/trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test/TestNetworkTimeout.java:[75,36] error: not a statement Please fix and we'll try again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there was a typo in the fix
@@ -64,10 +72,19 @@ public void testGetNetworkTimeout() { | |||
Connection conn = null; | |||
try { | |||
System.out.println("Connecting to database..."); | |||
conn = Utils.getUserConnection(); | |||
conn = Utils.getUserConnection();S |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra "S" at the end of the line appears to be causing the JDBC build failure
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2260/ |
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2260/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Looks good to me
some classes in incubator-trafodion/dcs/src/test/jdbc_test/src/test/java/org/trafodion/jdbc_test do not close statement and connection, which will lead to no connection can be use.
classes include :
PropTest.java
TestNetworkTimeout.java
TestWrap.java