-
Notifications
You must be signed in to change notification settings - Fork 154
Trafodion 1949: New JDBC Type 4 Programmer's Reference Guide #457
Conversation
New guide. Added missing SPJ Guide file.
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/681/ |
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/681/ |
<parent> | ||
<groupId>org.apache.trafodion</groupId> | ||
<artifactId>trafodion</artifactId> | ||
<version>1.3.0</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, this is the 1.3.0 version? Is there also a 2.0,0 version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document versions are driven from env.TRAFODION_VERSION. The value here is
required but doesn't have a meaning that I'm aware of.
On Fri, Apr 29, 2016 at 5:27 PM, DaveBirdsall notifications@github.com
wrote:
In docs/jdbct4ref_guide/pom.xml
#457 (comment)
:+* @@@ END COPYRIGHT @@@
+-->
- 4.0.0
- org.apache.trafodion
- jdbct4-ref-guide
- ${env.TRAFODION_VER}
- pom
- Trafodion JDBC Type 4 Programmer's Reference Guide
- This document describes how to use the JDBC Type 4 Driver.
- http://trafodion.incubator.apache.org
- 2015
- org.apache.trafodion
- trafodion
- 1.3.0
So, this is the 1.3.0 version? Is there also a 2.0,0 version?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/apache/incubator-trafodion/pull/457/files/a3cc57d7f87c8f89148fe34f729e9c630e9e2091#r61657384
Thanks,
Gunnar
If you think you can you can, if you think you can't you're right.
I've skimmed this. Looks good. Will commit on Monday (leaving some time for other reviewers). |
|
||
All JDBC data source classes implement either the `javax.sql.DataSource` | ||
interface or the `javax.sql.ConnectionPoolDataSource` interface. The Type | ||
4 driver data source classes are `org.trafodion.t4jdbc.HPT4DataSource` and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be org.trafodion.jdbc.t4 instead of org.trafodion.t4jdbc
property names and values as indicated in the following list: | ||
|
||
``` | ||
url=jdbc:hpt4jdbc://<primary IP addr or host name of database>:37800/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change url and catalog name from seabase to TRAFODION
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. Also changed port number.
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/692/ |
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/692/ |
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/693/ |
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/693/ |
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/694/ |
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/694/ |
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/695/ |
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/695/ |
Please wait with merging this change until Anu has had a chance to review the changes in the JDBC T4 guide. |
Yes, that was my plan. Will poll all reviewers to see if the latest is acceptable before merging. |
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/705/ |
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/705/ |
Checking again: Is this ready for merge? @hegdean, do you have more review comments? |
I don't have any more comments. blob/clob sections/information should be hidden till it is enabled by default. |
They are hidden. On Thu, May 5, 2016 at 9:29 AM, hegdean notifications@github.com wrote:
Thanks, Gunnar |
Sounds like it's ready to merge then. Will do it later today. |
For review. This guide isn't visible externally yet. Chapters/information related to blob/clob are commented out but part of the checkin.
Also changed the location of the Apache incubator logo from 300px to 200px right indent.
Added a missing source file for the SPJ Guide.