Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

TRAFODION-2067 support cdh5.7 & hbase1.2 #610

Closed
wants to merge 5 commits into from
Closed

TRAFODION-2067 support cdh5.7 & hbase1.2 #610

wants to merge 5 commits into from

Conversation

mashengchen
Copy link
Contributor

@mashengchen mashengchen commented Jul 21, 2016

  1. support cdh5.7 & hbase1.2. add hbase-trx-cdh5.7.jar & hbase-trx-apache1.2.jar
  2. HBASE_DISTRO add CDH5.7 APACHE1.2
  3. remove cdh & apache & cdh version in trafodion-dtm-.jar & trafodion-sql-.jar & trafodion-utility-.jar, they will be trafodion-dtm-[apache][cdh][hdp]-$trafodion_version.jar & trafodion-sql-[apache][cdh][hdp]-$trafodion_version.jar & trafodion-utility-$trafodion_version.jar . becacuse we can't determine which version user will install. and we only have one version of each jar. but not hbase-trx.jar, so hbase-trx*.jar have version, because they have multi version. eg: for cdh they have hbase-trx-cdh5_4-2.1.0.jar & hbase-trx-cdh5_5-2.1.0.jar & hbase-trx-cdh5_7-2.1.0.jar
  4. HBASE1.* ->APACHE1.* in .tmpl files.
  5. do some optimize in traf_config_check

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/946/

@Traf-Jenkins
Copy link

@moscowgentalman
Copy link
Contributor

Looks good for me.

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/949/

@Traf-Jenkins
Copy link

@DaveBirdsall
Copy link
Contributor

Looks good to me.

@amandamoran
Copy link
Contributor

amandamoran commented Jul 26, 2016

I tested these changes on CDH 5.7 on a 2 node cluster.

[trafodion@addnode-4 ~]$ sqlci
Apache Trafodion Conversational Interface 2.1.0
Copyright (c) 2015-2016 Apache Software Foundation

create table toby (f1 int, f2 int);
--- SQL operation complete.
get tables;

Tables in Schema TRAFODION.SEABASE

TOBY
--- SQL operation complete.
exit
End of MXCI Session

[trafodion@addnode-4 ~]$ echo $CDH_VERSION
5.7

There are some more install changes that need to be made to support this, but I can make those in another pull request. (For example CDH_5_7_SUPPORT is not being added to /etc/trafodion/trafodion_config and the HBase Version during trafodion_install).

07/28: Here are the additional install changes
#625

@sbroeder
Copy link
Contributor

I'm able to use maven to build the coprocessor/transactional/generated/TrxRegionProtos.java file for the pom.xml.apache* files, but I can't for the pom.xml.cdh* files. Can you tell me which version of protoc you are using and what command you use to build these files?

@amandamoran
Copy link
Contributor

amandamoran commented Jul 28, 2016

CDH 5.8 came out today. I tested these changes on a single node CDH 5.8 system and it worked great!

[trafodion@cdh-58 ~]$ sqcheck

*** Checking Trafodion Environment ***

Checking if processes are up.
Checking attempt: 1; user specified max: 2. Execution time in seconds: 0.

The Trafodion environment is up!

Process Configured Actual Down


DTM 2 2
RMS 4 4
DcsMaster 1 1
DcsServer 1 1
mxosrvr 8 8

RestServer 1 1

[trafodion@cdh-58 ~]$ sqlci
Apache Trafodion Conversational Interface 2.1.0
Copyright (c) 2015-2016 Apache Software Foundation

create table toby (f1 int, f2 int);

--- SQL operation complete.

insert into toby values (8,10);

--- 1 row(s) inserted.

get tables;

TOBY

--- SQL operation complete.

select * from toby;

F1 F2


      8           10

--- 1 row(s) selected.

exit

End of MXCI Session

@mashengchen
Copy link
Contributor Author

@sbroeder
pls use 2.5
and i used to use protoc to gen TrxRegionProtos.java first, after gen the file .you can do make under /hbase-trx.

@moscowgentalman
Copy link
Contributor

Is this ready for merge?

@@ -4241,8 +4257,12 @@ CoprocessorService, Coprocessor {
e.add(kv);
try {
final WALKey wk = new WALKey(this.regionInfo.getEncodedNameAsBytes(), this.regionInfo.getTable(), EnvironmentEdgeManager.currentTime());
#ifdef CDH5.7 APACHE1.2
txid = this.tHLog.append(this.m_Region.getTableDesc(), this.regionInfo, wk, e, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sequenceID gets missing here during logging. Please confirm this does not have side effects during recovery.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do a test and find out there is no side effect

before cdh5.7

2016-08-04 05:44:09,318 TRACE [B.defaultRpcServer.handler=17,queue=2,port=35946] transactional.TrxRegionEndpoint: TrxRegionEndpoint coprocessor: commit - txId 3, Write commit HLOG seq 274
----do sqstop && swsopall and do sqstart && swstartall
2016-08-04 06:44:48,680 TRACE [B.defaultRpcServer.handler=29,queue=2,port=43771] transactional.TrxRegionEndpoint: TrxRegionEndpoint coprocessor: commit - txId 3, Write commit HLOG seq 214

cdh 5.7

2016-08-04 06:18:52,101 TRACE [PriorityRpcServer.handler=5,queue=1,port=58401] transactional.TrxRegionEndpoint: TrxRegionEndpoint coprocessor: commit - txId 3, Write commit HLOG seq 227

@prashanth-vasudev
Copy link
Contributor

Reviewed the changes. Except for few comments added, rest looks good. Please address those comments and run full regressions before the merge. Thanks.

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1013/

@Traf-Jenkins
Copy link

@mashengchen
Copy link
Contributor Author

jenkins ,retest

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1032/

@Traf-Jenkins
Copy link

@mashengchen
Copy link
Contributor Author

jenkins, retest

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1035/

@Traf-Jenkins
Copy link

@moscowgentalman
Copy link
Contributor

jenkins, retest

@Traf-Jenkins
Copy link

New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1037/

@Traf-Jenkins
Copy link

@arvind-narain
Copy link
Contributor

arvind-narain commented Aug 11, 2016

The build error seems to be the following. Maybe this is will go once rebase is done and conflicts are resolved ? Change in installer/.gitignore for DISCLAIMER went in 15 days back.

Error: Build created 1 untracked file(s)
Update .gitignore files
install/installer/DISCLAIMER

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
8 participants