TRAFODION-2067 support cdh5.7 & hbase1.2 #610
Conversation
mashengchen
commented
Jul 21, 2016
•
edited
edited
- support cdh5.7 & hbase1.2. add hbase-trx-cdh5.7.jar & hbase-trx-apache1.2.jar
- HBASE_DISTRO add CDH5.7 APACHE1.2
- remove cdh & apache & cdh version in trafodion-dtm-.jar & trafodion-sql-.jar & trafodion-utility-.jar, they will be trafodion-dtm-[apache][cdh][hdp]-$trafodion_version.jar & trafodion-sql-[apache][cdh][hdp]-$trafodion_version.jar & trafodion-utility-$trafodion_version.jar . becacuse we can't determine which version user will install. and we only have one version of each jar. but not hbase-trx.jar, so hbase-trx*.jar have version, because they have multi version. eg: for cdh they have hbase-trx-cdh5_4-2.1.0.jar & hbase-trx-cdh5_5-2.1.0.jar & hbase-trx-cdh5_7-2.1.0.jar
- HBASE1.* ->APACHE1.* in .tmpl files.
- do some optimize in traf_config_check
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/946/ |
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/946/ |
Looks good for me. |
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/949/ |
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/949/ |
Looks good to me. |
I tested these changes on CDH 5.7 on a 2 node cluster. [trafodion@addnode-4 ~]$ sqlci
[trafodion@addnode-4 ~]$ echo $CDH_VERSION There are some more install changes that need to be made to support this, but I can make those in another pull request. (For example CDH_5_7_SUPPORT is not being added to /etc/trafodion/trafodion_config and the HBase Version during trafodion_install). 07/28: Here are the additional install changes |
I'm able to use maven to build the coprocessor/transactional/generated/TrxRegionProtos.java file for the pom.xml.apache* files, but I can't for the pom.xml.cdh* files. Can you tell me which version of protoc you are using and what command you use to build these files? |
CDH 5.8 came out today. I tested these changes on a single node CDH 5.8 system and it worked great![trafodion@cdh-58 ~]$ sqcheck *** Checking Trafodion Environment *** Checking if processes are up. The Trafodion environment is up! Process Configured Actual Down DTM 2 2 RestServer 1 1 [trafodion@cdh-58 ~]$ sqlci
--- SQL operation complete.
--- 1 row(s) inserted.
TOBY --- SQL operation complete.
F1 F2
--- 1 row(s) selected.
End of MXCI Session |
@sbroeder |
Is this ready for merge? |
@@ -4241,8 +4257,12 @@ CoprocessorService, Coprocessor { | |||
e.add(kv); | |||
try { | |||
final WALKey wk = new WALKey(this.regionInfo.getEncodedNameAsBytes(), this.regionInfo.getTable(), EnvironmentEdgeManager.currentTime()); | |||
#ifdef CDH5.7 APACHE1.2 | |||
txid = this.tHLog.append(this.m_Region.getTableDesc(), this.regionInfo, wk, e, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sequenceID gets missing here during logging. Please confirm this does not have side effects during recovery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i do a test and find out there is no side effect
before cdh5.7
2016-08-04 05:44:09,318 TRACE [B.defaultRpcServer.handler=17,queue=2,port=35946] transactional.TrxRegionEndpoint: TrxRegionEndpoint coprocessor: commit - txId 3, Write commit HLOG seq 274
----do sqstop && swsopall and do sqstart && swstartall
2016-08-04 06:44:48,680 TRACE [B.defaultRpcServer.handler=29,queue=2,port=43771] transactional.TrxRegionEndpoint: TrxRegionEndpoint coprocessor: commit - txId 3, Write commit HLOG seq 214
cdh 5.7
2016-08-04 06:18:52,101 TRACE [PriorityRpcServer.handler=5,queue=1,port=58401] transactional.TrxRegionEndpoint: TrxRegionEndpoint coprocessor: commit - txId 3, Write commit HLOG seq 227
Reviewed the changes. Except for few comments added, rest looks good. Please address those comments and run full regressions before the merge. Thanks. |
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1013/ |
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/1013/ |
jenkins ,retest |
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1032/ |
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/1032/ |
jenkins, retest |
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1035/ |
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/1035/ |
jenkins, retest |
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1037/ |
Test Failed. https://jenkins.esgyn.com/job/Check-PR-master/1037/ |
The build error seems to be the following. Maybe this is will go once rebase is done and conflicts are resolved ? Change in installer/.gitignore for DISCLAIMER went in 15 days back. Error: Build created 1 untracked file(s) |