Fixes for Jira's trafodion-19 & trafodion-29 #62
Conversation
See Jira's for a description. Also removed obsolete code from the parser
Conflicts: core/sql/sqlcomp/CmpSeabaseDDL.h core/sql/sqlcomp/CmpSeabaseDDLtable.cpp
|
Test Failed. |
|
Test Passed. |
| @@ -99,3 +99,17 @@ NABoolean ComIsTrafodionReservedSchemaName( | |||
| return FALSE; | |||
| } | |||
|
|
|||
| // schema names of pattern "_HV ... _" and "_HB_ ... _" are reserved to store | |||
There was a problem hiding this comment.
Nit: Comment is not quite right... it's HV and HB (the trailing underscore after _HV is missing).
There was a problem hiding this comment.
The ... was supposed to signify the schema name, perhaps "HV_schema" and "HB_schema" would look better. The ... to indicate the schema name may be confusing. I have updated the comment and will be part of my next delivery.
There was a problem hiding this comment.
sorry, I did not catch the "underscore" comment - I will fix this in a subsequent delivery.
|
The changes look good to me. The only comments I had were fairly minor. |
| 1180 ZZZZZ 99999 BEGINNER MAJOR DBADMIN The required subvolume name for locations in schema $0~SchemaName is $1~String0. | ||
| 1181 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Label $0~String0 could not be dropped (file error $1~NSKCode). | ||
| 1180 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Trying to create an external table $0~TableName with a different schema or table name than the source table $1~TableName. The external schema and table name must be the same as the source. | ||
| 1181 ZZZZZ 99999 BEGINNER MAJOR DBADMIN Trying to create a schema with name $0~TableName to store the definition of a native HIVE or HBASE table and the name is too long. Maximum length supported is $0~Int0. |
There was a problem hiding this comment.
Can we supply the external source as an argument (HIVE or HBASE) here?
There was a problem hiding this comment.
Can do, good suggestion.
See Jira's for a description.
Also removed obsolete code from the parser