[TRAFODION-2229] add Hashing functions to Trafodion #813
Conversation
…o TRAFODION-2229 Conflicts: core/sql/exp/exp_clause.h
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1318/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/1318/ |
|
+1 |
| } | ||
|
|
||
|
|
||
| | TOK_SHA1 '(' value_expression ')' |
There was a problem hiding this comment.
Looks like this production is in there twice?
There was a problem hiding this comment.
thanks Dave for catching this, this is a bug, will fix.
| 1, $3); | ||
| } | ||
|
|
||
| | TOK_SHA2 '(' value_expression ')' |
There was a problem hiding this comment.
Looks like this production is here twice?
| ITM_MD5 = 2635, | ||
| ITM_SHA1 = 2636, | ||
| ITM_SHA2 = 2637, | ||
| ITM_SHA = 2638, |
There was a problem hiding this comment.
ITM_SHA is never used. Looking at the parser changes, it appears that SHA is simply a syntactic sugar meaning the same as SHA1, so the difference between SHA and SHA1 disappears after parsing. So ITM_SHA is not needed.
There was a problem hiding this comment.
I can refactor the code to remove ITM_SHA
| FUNC_MD5_ID = 123, | ||
| FUNC_SHA1_ID = 124, | ||
| FUNC_SHA2_ID = 125, | ||
| FUNC_SHA_ID = 126 |
There was a problem hiding this comment.
FUNC_SHA_ID is never used and should be deleted.
| @@ -40,6 +40,10 @@ | |||
|
|
|||
|
|
|||
| #include <math.h> | |||
| #include <zlib.h> | |||
| #include "openssl/md5.h" | |||
There was a problem hiding this comment.
I'm wondering why this isn't <openssl/md5.h>. Seems like one would have to copy the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant to use angle brackets instead of quotes?
| SHA256_Init(&sha_ctx); | ||
| SHA256_Update(&sha_ctx, op_data[1], slen); | ||
| SHA256_Final((unsigned char*) sha,&sha_ctx); | ||
| char tmp[2]; |
There was a problem hiding this comment.
Looks too short. The sprintf will write three bytes (two digits + a null terminator), so it will overrun this buffer.
There was a problem hiding this comment.
agree, will fix
| SHA1_Init(&sha_ctx); | ||
| SHA1_Update(&sha_ctx, op_data[1], slen); | ||
| SHA1_Final((unsigned char*) sha,&sha_ctx); | ||
| char tmp[2]; |
There was a problem hiding this comment.
This buffer is too short.
| MD5_Init(&md5_ctx); | ||
| MD5_Update(&md5_ctx, op_data[1], slen); | ||
| MD5_Final((unsigned char*) md5,&md5_ctx); | ||
| char tmp[2]; |
There was a problem hiding this comment.
This buffer is too short.
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1324/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/1324/ |
|
@DaveBirdsall please help to review again, I update according to your comments. And add a few regression tests. |
|
+1 Nice change |
|
Thanks all for the review, I will merge this if no other comments. I fixed all previous comments in last commit. |
|
I will take a quick look now... |
Compatibility enhancement
add new functions for MySQL:
CRC32() Compute a cyclic redundancy check value
MD5() Calculate MD5 checksum
SHA1(), SHA() Calculate an SHA-1 160-bit checksum
SHA2() Calculate an SHA-2 checksum
Unit test is to test several input value, and invoke same query in MySQL, and compare the result. Pass the test since results are same.