This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
[TRAFODION-2470] Fixed one cause of 6004 warnings #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1589/ |
zellerh
approved these changes
Feb 2, 2017
core/sql/parser/SqlParserAux.cpp
Outdated
| @@ -863,8 +863,7 @@ ItemExpr *literalOfNumericPassingScale(NAString *strptr, char sign, | |||
| } else if (strSize <= 19) { | |||
| datatype = (createSignedDatatype ? REC_BIN64_SIGNED : REC_BIN64_UNSIGNED); | |||
| length = sizeof(Int64); | |||
| } else if (strSize == 20) { | |||
| createSignedDatatype = FALSE; | |||
| } else if ((strSize == 20) && (!createSignedDatatype)) { | |||
There was a problem hiding this comment.
This is in the surround, but I wonder whether we shouldn't also look at the TRAF_LARGEINT_UNSIGNED_IO CQD and only generate unsigned largeint literals if that CQD is set to ON.
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/1589/ |
|
Thanks, @zellerh, for the suggestion. I agree, and it was easy to make the suggested change, so I made it. |
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1590/ |
|
+1 Thank you for adding this! |
|
+1 |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/1590/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function literalOfNumericPassingScale (parser/SqlParserAux.cpp) is used to parse literals into ConstValue nodes and encoded values. It was incorrectly handling signed numeric literals of 20 characters in length: it would encode these as an unsigned 64-bit integer, then create a signed SQLLargeInt or SQLNumeric with that unsigned encoded value. One symptom of this is that histograms for NUMERIC datatypes would encounter 6004 errors (out-of-order histogram intervals) if there were some values requiring less than 20 characters and others requiring 20 or more.
The fix here reverts to using SQLBigNum instead for such values.