Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

[TRAFODION-2513] jdbcT4 profile configuration for publish to maven central #983

Closed
wants to merge 1 commit into from

Conversation

AlexPeng19
Copy link
Contributor

jira13493

@Traf-Jenkins
Copy link

Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/1634/

@Traf-Jenkins
Copy link

@DaveBirdsall
Copy link
Contributor

There doesn't seem to be any JIRA with this number.

If you put [TRAFODION-nnnn] (where nnnn is the JIRA number) into the title of your pull request, then the JIRA will be automatically updated.

@AlexPeng19 AlexPeng19 changed the title jira13493 INFRA-13493 Mar 1, 2017
@AlexPeng19
Copy link
Contributor Author

@DaveBirdsall my mistake, it's called INFRA, i renamed the title. please check. here is the link https://issues.apache.org/jira/browse/INFRA-13493?filter=-2

@sandhyasun
Copy link
Contributor

sandhyasun commented Mar 1, 2017

Alex that INFRA JIRA is actually closed and we aren't doing any work on it. Can you please open a new Trafodion JIRA and descrivbe why this change is needed - i.e that it's needed to publish artifacts etc. If you like you may want to refer to the original close INFRA JIRA but lets not use the INFRA JIRA for this pull request since it is confusing to the reviewers/committers.

@AlexPeng19 AlexPeng19 changed the title INFRA-13493 TRAFODION-2513 Mar 1, 2017
@AlexPeng19
Copy link
Contributor Author

@sandhyasun thanks for you remind, i create one new jira and changed the tilte, please check.

<!--<parent>
<groupId>org.apache.trafodion</groupId>
<artifactId>trafodion</artifactId>
<version>1.3.0</version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the version number is 1.3.0 rather than 2.1.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xwq i refered our parent pom:
org.apache.trafodion
trafodion
1.3.0
pom
it's not necessary, in case any negative effects, i comment them.

@AlexPeng19 AlexPeng19 changed the title TRAFODION-2513 [TRAFODION-2513] jdbcT4 profile configuration for publish to maven central Mar 3, 2017
@DaveBirdsall
Copy link
Contributor

@svarnau, could you review this?

@svarnau
Copy link
Contributor

svarnau commented Mar 9, 2017

Looks fine to me, though I've never published to the Apache maven repo. Release manager will be the lucky one to do it for first time.

@DaveBirdsall
Copy link
Contributor

@sandhyasun, do you have any comments on this change?

@sandhyasun
Copy link
Contributor

This needs to go into 2.1 actually , doesn't it ? I'll have to do it the first time when we release 2.1

@sandhyasun
Copy link
Contributor

No need to merge this PR. The PR #1004 will get merged to branch 2.1 . And then it will make it's way to "master". So we can close/abandon this PR.

@moscowgentalman
Copy link
Contributor

@AlexPeng19 , please close this PR, thanks.

@AlexPeng19
Copy link
Contributor Author

@traflm ok

@AlexPeng19 AlexPeng19 closed this Mar 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants