Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TUBEMQ-163] Flume sink for TubeMQ #146

Merged
merged 4 commits into from
Jun 16, 2020
Merged

[TUBEMQ-163] Flume sink for TubeMQ #146

merged 4 commits into from
Jun 16, 2020

Conversation

yuanboliu
Copy link
Member

No description provided.

guangxuCheng
guangxuCheng reviewed Jun 11, 2020
View reviewed changes
Copy link
Member

@guangxuCheng guangxuCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is recommended to use tubemq instead of tube.

  1. tube -> tubemq
  2. Tube -> TubeMQ
  3. Tubemq -> TubeMQ

@dockerzhang
Copy link
Contributor

+1

@yuanboliu
Copy link
Member Author

@guangxuCheng

create a new PR for your comments:
dae923b6478aec60ebe024a170cb15821ef3a25d

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b2ddb28). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #146   +/-   ##
========================================
  Coverage          ?   7.96%           
  Complexity        ?     458           
========================================
  Files             ?     239           
  Lines             ?   26732           
  Branches          ?    4441           
========================================
  Hits              ?    2128           
  Misses            ?   24144           
  Partials          ?     460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ddb28...2a549f4. Read the comment docs.

gosonzhang
gosonzhang approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

gosonzhang
gosonzhang approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit 578d1bb into apache:master Jun 16, 2020
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
@leezng
[INLONG-1634] Migrate download documentation (apache#146)
ef8e1ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guangxuCheng guangxuCheng guangxuCheng left review comments

@gosonzhang gosonzhang gosonzhang approved these changes

@dockerzhang dockerzhang dockerzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yuanboliu @dockerzhang @codecov-commenter @gosonzhang @guangxuCheng