Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TUBEMQ-230] upgrade test dependency, support jdk13 #147

Merged
merged 2 commits into from
Jun 15, 2020
Merged

[TUBEMQ-230] upgrade test dependency, support jdk13 #147

merged 2 commits into from
Jun 15, 2020

Conversation

tensorchen
Copy link
Contributor

guangxuCheng
guangxuCheng approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@guangxuCheng guangxuCheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM +1

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@b2ddb28). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #147   +/-   ##
========================================
  Coverage          ?   7.63%           
  Complexity        ?     438           
========================================
  Files             ?     235           
  Lines             ?   26535           
  Branches          ?    4424           
========================================
  Hits              ?    2026           
  Misses            ?   24063           
  Partials          ?     446

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ddb28...c354bb7. Read the comment docs.

gosonzhang
gosonzhang approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit ef0b556 into apache:master Jun 15, 2020
@tensorchen tensorchen deleted the support_jdk13 branch June 15, 2020 13:42
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
@leezng
[INLONG-1635] Migrate development documentation (apache#147)
4d13235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosonzhang gosonzhang gosonzhang approved these changes

@guangxuCheng guangxuCheng guangxuCheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tensorchen @codecov-commenter @gosonzhang @guangxuCheng