Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUBEMQ-12]Change to use Apache License V2 #19

Merged
merged 6 commits into from Feb 11, 2020
Merged

[TUBEMQ-12]Change to use Apache License V2 #19

merged 6 commits into from Feb 11, 2020

Conversation

gosonzhang
Copy link
Contributor

No description provided.

@yiheng
Copy link
Contributor

yiheng commented Feb 10, 2020

can you highlight where do we enable RAT check? This change touches a lot of files. It's better to leave a comment on the change where enables the RAT check. (I try to search but not found)

@gosonzhang
Copy link
Contributor Author

gosonzhang commented Feb 10, 2020

This PR only changed LICENSE of files, the " enable RAT check" is copied from Jira name.

This PR only changed the permissions of the files. After the completion, I found that nearly 400 files were modified. In order to avoid mutual influence, I will propose PR amendments one by one according to the topic.

@yiheng
Copy link
Contributor

yiheng commented Feb 10, 2020

IMHO, the change is not reviewable without check in the enable RAT check change. No one can review such changes. Instead, if we enable the RAT check. The change can be verified automatically by the travis build job. Then we just need to review the RAT enable check change.

@guangxuCheng
Copy link
Member

Agree with what @yiheng said.

@gosonzhang
Copy link
Contributor Author

I checked the pom.xml, the rat check already existed, but not enabled in the CI script, but after the function was enabled, the entire compilation time took more than 20 minutes and it is not over yet.

It is better to enable RAT check locally before submitting pr or before incorporating the code, NOT in CI script.

@gosonzhang
Copy link
Contributor Author

After enable the RAT check, I found that the PR compilation time has been extended a lot, so I reverted the modification of the travis-ci script.

Everyone can enable CAT check by adding "apache-rat: check" to the mvn command line

@gosonzhang gosonzhang changed the title [TUBEMQ-12]Change to use Apache License V2 and enable RAT check [TUBEMQ-12]Change to use Apache License V2 Feb 10, 2020
@lizhiboo lizhiboo merged commit 9eaa8e5 into apache:master Feb 11, 2020
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants