Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUBEMQ-274]Support CMake compilation #197

Merged
merged 2 commits into from Jul 9, 2020
Merged

[TUBEMQ-274]Support CMake compilation #197

merged 2 commits into from Jul 9, 2020

Conversation

charlely
Copy link
Contributor

@charlely charlely commented Jul 9, 2020

[TUBEMQ-274]Support CMake compilation

@codecov-commenter
Copy link

Codecov Report

Merging #197 into tubemq-client-cpp will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             tubemq-client-cpp    #197      +/-   ##
======================================================
+ Coverage                 7.87%   7.89%   +0.01%     
- Complexity                 456     458       +2     
======================================================
  Files                      242     242              
  Lines                    26805   26805              
  Branches                  4447    4447              
======================================================
+ Hits                      2112    2115       +3     
+ Misses                   24229   24227       -2     
+ Partials                   464     463       -1     
Impacted Files Coverage Δ Complexity Δ
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 44.57% <0.00%> (+0.58%) 35.00% <0.00%> (+1.00%)
.../apache/tubemq/corebase/policies/FlowCtrlItem.java 40.00% <0.00%> (+1.11%) 9.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7592b0b...e9b41a5. Read the comment docs.

SET(CMAKE_CXX_FLAGS_DEBUG "-O1 -g -ggdb -D_DEBUG")
SET(CMAKE_CXX_FLAGS_RELEASE "-O3 -g -ggdb -DNDEBUG")
SET(DEPENDENT_LIBRARIES log4cplus pthread)
else (UNIX)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it repeated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cmake syntax is like this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I get it, thanks!

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit a1c69a1 into apache:tubemq-client-cpp Jul 9, 2020
guangxuCheng pushed a commit that referenced this pull request Sep 15, 2020
Co-authored-by: charleli <charleli@tencent.com>
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
Co-authored-by: dockerzhang <dockerzhang@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants