Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUBEMQ-439]Add Cli field Scheme definition #335

Merged
merged 2 commits into from
Dec 3, 2020
Merged

[TUBEMQ-439]Add Cli field Scheme definition #335

merged 2 commits into from
Dec 3, 2020

Conversation

gosonzhang
Copy link
Contributor

It is found that the field tokens used to interact with users in CLI or HTTP API requests have a relatively large overlap. This issue is hoped that a unified field output goal can be achieved through the field definition scheme, and the same attribute has a unified attribute definition and interpretation, which reduces the user's learning and use cost To maintain the consistency of interface interaction

Because CLI and HTTP API are not a complete closed loop, and there are still compatibility issues, the existing ones are defined first, and then the new field definitions and interfaces will be gradually standardized. When appropriate, we will update the outdated interfaces.

It should be noted that after the version is released, the existing definition fields in scheme cannot be modified, only new fields can be added

@codecov-io
Copy link

codecov-io commented Dec 2, 2020

Codecov Report

Merging #335 (35de731) into TUBEMQ-430 (c9fbda7) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##             TUBEMQ-430    #335      +/-   ##
===============================================
- Coverage          7.94%   7.91%   -0.04%     
- Complexity          465     466       +1     
===============================================
  Files               254     255       +1     
  Lines             27372   27404      +32     
  Branches           4479    4479              
===============================================
- Hits               2175    2169       -6     
- Misses            24728   24763      +35     
- Partials            469     472       +3     
Impacted Files Coverage Δ Complexity Δ
...e/tubemq/server/broker/web/BrokerAdminServlet.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...pache/tubemq/server/common/fielddef/CliArgDef.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...che/tubemq/server/common/fielddef/WebFieldDef.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../tubemq/server/common/utils/WebParameterUtils.java 2.47% <ø> (ø) 8.00 <0.00> (ø)
.../java/org/apache/flume/sink/tubemq/TubemqSink.java 51.42% <0.00%> (-4.00%) 14.00% <0.00%> (ø%)
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.70% <0.00%> (+0.39%) 21.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9fbda7...35de731. Read the comment docs.

@gosonzhang gosonzhang merged commit be4bdf0 into apache:TUBEMQ-430 Dec 3, 2020
@gosonzhang gosonzhang deleted the TUBEMQ-430 branch December 3, 2020 11:25
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants