Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUBEMQ-441]An error occurred when using the Tubemq class to create a sink table #339

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Conversation

gosonzhang
Copy link
Contributor

The reason for this problem is that the Tubemq class is shared in the source and sink, but the required parameters required by the source and sink are inconsistent, the Tubemq.toConnectorProperties() does not check whether the corresponding required parameters are met according to different ways of use.

The problem is solved by adding the consumerRole attribute (the default true, consumer role) and the role setting API asConsumer (boolean isConsumer) in the Tubemq class

@gosonzhang gosonzhang merged commit 288a2e3 into apache:master Dec 4, 2020
@gosonzhang gosonzhang deleted the TUBEMQ-441 branch December 4, 2020 09:37
EMsnap pushed a commit to EMsnap/incubator-tubemq that referenced this pull request Jan 7, 2021
… sink table (apache#339)

Co-authored-by: gosonzhang <gosonzhang@tencent.com>
EMsnap pushed a commit to EMsnap/incubator-tubemq that referenced this pull request Jan 7, 2021
… sink table (apache#339)

Co-authored-by: gosonzhang <gosonzhang@tencent.com>
yuanboliu pushed a commit that referenced this pull request Jan 29, 2021
… sink table (#339)

Co-authored-by: gosonzhang <gosonzhang@tencent.com>
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants