Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUBEMQ-445]Adjust the status check default sleep interval of pullConsumeReadyChkSliceMs #345

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

gosonzhang
Copy link
Contributor

Since the available status of the partition is also controlled by the server, if the detection sleep interval is too long, the partition consumption delay response will not be sensitive enough, so adjust the value to a smaller value.

Copy link
Contributor

@lamberliu lamberliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

Codecov Report

Merging #345 (014d9a0) into master (0d3f9c9) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #345      +/-   ##
===========================================
- Coverage      7.91%   7.81%   -0.10%     
- Complexity      466     468       +2     
===========================================
  Files           255     258       +3     
  Lines         27414   27891     +477     
  Branches       4486    4579      +93     
===========================================
+ Hits           2170    2180      +10     
- Misses        24771   25240     +469     
+ Partials        473     471       -2     
Impacted Files Coverage Δ Complexity Δ
.../apache/tubemq/client/common/TClientConstants.java 66.66% <ø> (ø) 1.00 <0.00> (ø)
...emq/client/consumer/SimplePullMessageConsumer.java 2.94% <0.00%> (-0.03%) 1.00 <0.00> (ø)
...a/org/apache/tubemq/corebase/utils/MixedUtils.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../org/apache/tubemq/corebase/TErrCodeConstants.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...pache/tubemq/server/common/fielddef/CliArgDef.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...pache/tubemq/server/tools/cli/CliAbstractBase.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...rg/apache/tubemq/server/tools/cli/CliProducer.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...rg/apache/tubemq/server/tools/cli/CliConsumer.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 44.57% <0.00%> (+0.58%) 35.00% <0.00%> (+1.00%)
.../apache/tubemq/corebase/policies/FlowCtrlItem.java 40.00% <0.00%> (+1.11%) 9.00% <0.00%> (+1.00%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d3f9c9...014d9a0. Read the comment docs.

@gosonzhang gosonzhang merged commit 43d2e7b into apache:master Dec 9, 2020
@gosonzhang gosonzhang deleted the TUBEMQ-445 branch December 9, 2020 10:25
EMsnap pushed a commit to EMsnap/incubator-tubemq that referenced this pull request Jan 7, 2021
…sumeReadyChkSliceMs (apache#345)

Co-authored-by: gosonzhang <gosonzhang@tencent.com>
EMsnap pushed a commit to EMsnap/incubator-tubemq that referenced this pull request Jan 7, 2021
…sumeReadyChkSliceMs (apache#345)

Co-authored-by: gosonzhang <gosonzhang@tencent.com>
yuanboliu pushed a commit that referenced this pull request Jan 29, 2021
…sumeReadyChkSliceMs (#345)

Co-authored-by: gosonzhang <gosonzhang@tencent.com>
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants