Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUBEMQ-446]Small bugs fix that do not affect the main logics #346

Merged
merged 2 commits into from
Dec 10, 2020
Merged

[TUBEMQ-446]Small bugs fix that do not affect the main logics #346

merged 2 commits into from
Dec 10, 2020

Conversation

gosonzhang
Copy link
Contributor

@gosonzhang gosonzhang commented Dec 9, 2020

Found some small bugs

  1. AddressUtils.getIPV4LocalAddress() should first check whether localIPAddress has been set, and use it directly under the premise that it has been set to reduce unnecessary get operations;
  2. The fetchCount parameter in MessageConsumerExample may be negative, so the executorService object should not use fetchCount as the initial value.
  3. Remove the useless parameter WITHOUTDELAY

Copy link
Contributor

@lamberliu lamberliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Dec 9, 2020

Codecov Report

Merging #346 (03d1cb0) into master (43d2e7b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #346      +/-   ##
===========================================
- Coverage      7.73%   7.73%   -0.01%     
  Complexity      464     464              
===========================================
  Files           258     258              
  Lines         27891   27892       +1     
  Branches       4579    4579              
===========================================
  Hits           2157    2157              
- Misses        25268   25269       +1     
  Partials        466     466              
Impacted Files Coverage Δ Complexity Δ
...org/apache/tubemq/corebase/utils/AddressUtils.java 10.71% <0.00%> (-0.16%) 5.00 <2.00> (ø)
...rg/apache/tubemq/server/tools/cli/CliConsumer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 42.52% <0.00%> (ø) 34.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d2e7b...03d1cb0. Read the comment docs.

@gosonzhang gosonzhang merged commit 66a9491 into apache:master Dec 10, 2020
@gosonzhang gosonzhang deleted the TUBEMQ-446 branch December 10, 2020 01:24
EMsnap pushed a commit to EMsnap/incubator-tubemq that referenced this pull request Jan 7, 2021
…#346)

Co-authored-by: gosonzhang <gosonzhang@tencent.com>
EMsnap pushed a commit to EMsnap/incubator-tubemq that referenced this pull request Jan 7, 2021
…#346)

Co-authored-by: gosonzhang <gosonzhang@tencent.com>
yuanboliu pushed a commit that referenced this pull request Jan 29, 2021
Co-authored-by: gosonzhang <gosonzhang@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants