Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUBEMQ-447] Add Broker-Admin Cli #347

Merged
merged 1 commit into from
Dec 11, 2020
Merged

[TUBEMQ-447] Add Broker-Admin Cli #347

merged 1 commit into from
Dec 11, 2020

Conversation

gosonzhang
Copy link
Contributor

  1. Add Broker-Admin's Cli command, directly enter the command(deficiency: I want to implement the command and then bring the sub-command mode, and found that commons-cli cannot support my own ideas, temporarily adopt this plan, and adjust it when there is a better plan );
  2. Modify some implementation bugs of web-api

@codecov-io
Copy link

Codecov Report

Merging #347 (512fe6b) into master (66a9491) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #347      +/-   ##
===========================================
- Coverage      7.80%   7.77%   -0.04%     
  Complexity      466     466              
===========================================
  Files           258     260       +2     
  Lines         27892   28000     +108     
  Branches       4579    4597      +18     
===========================================
  Hits           2177    2177              
- Misses        25242   25350     +108     
  Partials        473     473              
Impacted Files Coverage Δ Complexity Δ
...e/tubemq/server/broker/web/AbstractWebHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/tubemq/server/broker/web/BrokerAdminServlet.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...pache/tubemq/server/common/fielddef/CliArgDef.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...che/tubemq/server/common/fielddef/WebFieldDef.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...g/apache/tubemq/server/common/utils/HttpUtils.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../tubemq/server/common/webbase/WebMethodMapper.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...tubemq/server/master/web/action/screen/Webapi.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...pache/tubemq/server/tools/cli/CliAbstractBase.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...apache/tubemq/server/tools/cli/CliBrokerAdmin.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rg/apache/tubemq/server/tools/cli/CliConsumer.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a9491...512fe6b. Read the comment docs.

Copy link
Contributor

@lamberliu lamberliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gosonzhang gosonzhang merged commit edcd038 into apache:master Dec 11, 2020
@gosonzhang gosonzhang deleted the TUBEMQ-447 branch December 11, 2020 11:15
EMsnap pushed a commit to EMsnap/incubator-tubemq that referenced this pull request Jan 7, 2021
Co-authored-by: gosonzhang <gosonzhang@tencent.com>
EMsnap pushed a commit to EMsnap/incubator-tubemq that referenced this pull request Jan 7, 2021
Co-authored-by: gosonzhang <gosonzhang@tencent.com>
yuanboliu pushed a commit that referenced this pull request Jan 29, 2021
Co-authored-by: gosonzhang <gosonzhang@tencent.com>
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants