[TUBEMQ-451]Replace ConsumeTupleInfo with Tuple2 #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Yes, I know, the apache common jar includes Pair and Triple classes. In this scenario, I just do a simple return result encapsulation, without much content, and don’t want to introduce a large class for a return value encapsulation class to make the system very bloated; at the same time, I think its scheme is too rigid, tuple can be 2-tuples, 3-tuples, 4-tuples, etc, if only Pair and Triple are allowed, this is not good for subsequent program definitions. |
gosonzhang
added a commit
that referenced
this pull request
Dec 20, 2020
Co-authored-by: gosonzhang <gosonzhang@tencent.com>
EMsnap
pushed a commit
to EMsnap/incubator-tubemq
that referenced
this pull request
Jan 7, 2021
Co-authored-by: gosonzhang <gosonzhang@tencent.com>
EMsnap
pushed a commit
to EMsnap/incubator-tubemq
that referenced
this pull request
Jan 7, 2021
Co-authored-by: gosonzhang <gosonzhang@tencent.com>
yuanboliu
pushed a commit
that referenced
this pull request
Jan 29, 2021
Co-authored-by: gosonzhang <gosonzhang@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of ConsumeTupleInfo can be completely replaced by Tuple2 to reduces duplicate class definitions.