Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUBEMQ-127] Fixed a bug & minor changes #85

Merged
merged 1 commit into from May 19, 2020
Merged

Conversation

viviel
Copy link
Contributor

@viviel viviel commented May 18, 2020

  1. Fixed a bug
    Syntax error
map.keySet().iterator(); (1.8 syntax) -> new ArrayList<>(map.keySet()).iterator();
  1. Minor changes
if (curToken != null && curToken == usedToken) {
    return true;
}

change to

return curToken != null && curToken == usedToken;
if (isReged == null) {
    return true;
}

change to

return isReged == null;
List<String> partKeys = new ArrayList<>();
partKeys.addAll(partitionUsedMap.keySet());

change to

List<String> partKeys = new ArrayList<>(partitionUsedMap.keySet());

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit c4380d2 into apache:master May 19, 2020
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
Co-authored-by: healzhou <healzhou@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants