Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUBEMQ-138] Optimize core module test case code #87

Merged
merged 1 commit into from May 21, 2020

Conversation

viviel
Copy link
Contributor

@viviel viviel commented May 20, 2020

  1. Optimize the use of assertions
  2. Fix possible null pointer exception
SSLEngine sslEngine = null;
try {
    // create engine
    sslEngine = TSSLEngineUtil.createSSLEngine(keyStorePath, trustStorePath,
    keyStorePassword, trustStorePassword, true, false);
} catch (Throwable e) {
    e.printStackTrace();
}
// If the above code is a field, it may cause the object sslEngine is null
boolean needClientAuth = sslEngine.getNeedClientAuth();

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit 886319e into apache:master May 21, 2020
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
* [INLONG-682] Adjust the quick_start content of website.

* [INLONG-682] Adjust the quick_start content of website.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants