Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Generated Maven pom.xml have incorrect information #141

Closed
bdemers opened this issue Jul 30, 2020 · 2 comments
Closed

Generated Maven pom.xml have incorrect information #141

bdemers opened this issue Jul 30, 2020 · 2 comments
Milestone

Comments

@bdemers
Copy link
Member

bdemers commented Jul 30, 2020

I just updated from 0.10.0 and one of the things I noticed was the pom file changes:

The packaging listed in the pom looks wrong, it's listed as pom and it likely should be jar (or not defined)
https://repo1.maven.org/maven2/org/apache/tuweni/tuweni-bytes/1.1.0/tuweni-bytes-1.1.0.pom

This is minor, but... the "name" field is wrong in the project poms, this field is commonly used in reports. for example usage of the maven-notice-plugin uses the name field. The "name" tuweni-bytes is now task ':bytes:jar' property 'archiveBaseName'

Generated output diff example from the maven-notice-plugin:

-  tuweni-bytes under The Apache License, Version 2.0
-  tuweni-crypto under The Apache License, Version 2.0
-  tuweni-io under The Apache License, Version 2.0
-  tuweni-units under The Apache License, Version 2.0
+  task ':bytes:jar' property 'archiveBaseName' under The Apache License, Version 2.0
+  task ':crypto:jar' property 'archiveBaseName' under The Apache License, Version 2.0
+  task ':io:jar' property 'archiveBaseName' under The Apache License, Version 2.0
+  task ':units:jar' property 'archiveBaseName' under The Apache License, Version 2.0

NOTE: I'm just providing the above diff as an example of how the name from a pom file may be used.

@atoulme
Copy link
Member

atoulme commented Aug 6, 2020

Indeed, sorry about this. This was fixed in master, I think, though it's hard to test for this without running a local install.

Will be fixed for 1.2.0.

@atoulme atoulme added this to the 1.2.0 milestone Aug 6, 2020
@atoulme
Copy link
Member

atoulme commented Oct 19, 2020

This is now fixed in 1.2.0.

@atoulme atoulme closed this as completed Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants