Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

Implement max active connections in RLPxService #285

Closed
atoulme opened this issue Jun 18, 2021 · 2 comments · Fixed by #497
Closed

Implement max active connections in RLPxService #285

atoulme opened this issue Jun 18, 2021 · 2 comments · Fixed by #497
Labels
Stale

Comments

@atoulme
Copy link
Member

atoulme commented Jun 18, 2021

We don't implement a max number of connections right now for the RLPxService.

We should have a max, and when asked to connect to more endpoints than the max, put in a queue.
@atoulme
Copy link
Member Author

atoulme commented Jul 25, 2021

It hasn't been that bad and I see we can support a fair load of connections, so it might be worth delaying this as it starts getting complex.

@github-actions
Copy link

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jan 17, 2023
@atoulme atoulme mentioned this issue Jan 29, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to configure max clients of rlpx service atoulme/tuweni
1 participant
@atoulme