[Bugfix][TOPI] conv2d_transpose bugfix #3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhliu
approved these changes
May 6, 2019
merrymercy
reviewed
May 11, 2019
| @@ -193,13 +192,13 @@ def _callback(op): | |||
| rco, rcm, rci = cfg['tile_rc'].apply(s, OL, rc) | |||
| s[OL].reorder(rco, rcm, ry, rx, rci, n, f, y, x) | |||
|
|
|||
| s[AA].compute_at(s[OL], rcm) | |||
| s[WW].compute_at(s[OL], rcm) | |||
| s[AA].compute_at(s[OL], rx) | |||
There was a problem hiding this comment.
@Laurawly Why cannot we compute at rcm？
There was a problem hiding this comment.
We get blockidx.x not found error in certain cases such as the test I added in this pr
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
* deconv tests * deconv bug fixed for certain cases tests added
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
* deconv tests * deconv bug fixed for certain cases tests added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deconv casts blockIdx.x blockIdx.y arguments not found error in some cases, bug fixed, corresponding tests added. @merrymercy