Fix incorrect call to Unicode Win32 InetPton

[jmorrill]

The recent commit for #4281 is calling the Win32 MACRO InetPton. If the Visual studio project is set to "Use Unicode Character Set", (which tvm.dll seems to be) this calls InetPtonW, which uses wchar_t* (aka PCWSTR). This causes a build error as the "addr_buf" is a char*.

From InetPton docs:

When UNICODE or _UNICODE is defined, InetPton is defined to InetPtonW, the Unicode version of this function. The pszAddrString parameter is defined to the PCWSTR data type.

When UNICODE or _UNICODE is not defined, InetPton is defined to InetPtonA, the ANSI version of this function. The ANSI version of this function is always defined as inet_pton. The pszAddrString parameter is defined to the PCSTR data type.

This can be fixed by directly calling InetPtonA, which is safe as the tvm function always uses a char* for add_str and InetPtonA always takes a char* (aka PCSTR)

[soiferj]

LGTM

[FrozenGene]

Thanks! LGTM.

[FrozenGene]

@jmorrill I have read the doc: https://docs.microsoft.com/en-us/windows/win32/api/ws2tcpip/nf-ws2tcpip-inetptonw. Seems that Windows has Unix's inet_pton function too. i.e. InetPtonA defines. Do you think we should be better to use inet_pton directly and needn't distinguish _WIN32 / Unix?

i.e.

inline bool ValidateIP(std::string ip) {
  if (ip == "localhost") {
    return true;
  }
  struct sockaddr_in sa_ipv4;
  struct sockaddr_in6 sa_ipv6;
  bool is_ipv4 = inet_pton(AF_INET, ip.c_str(), &(sa_ipv4.sin_addr));
  bool is_ipv6 = inet_pton(AF_INET6, ip.c_str(), &(sa_ipv6.sin6_addr));
  return is_ipv4 || is_ipv6;
}

And I am curious why we don't function redefinition error because Windows has inet_pton too.

[FrozenGene]

Maybe be better to remove? Because WIndows / Unix both have inet_pton as comment said before

[jmorrill]

Good find! I removed the "static inline int inet_pton" function from socket.h and got a successful build on Windows.

Should I close this PR and resubmit a new PR with it removed?

[tqchen]

@jmorrill seems there was some problem in rebasing, please cherry pick your windows change and rebase against the master

[jmorrill]

Sorry you are dealing with a n00b, I'm still new with these git features.

The commit we want is here: 6f96747

git fetch upstream
git rebase upstream/master

Reports everything up to date

[FrozenGene]

Sorry you are dealing with a n00b, I'm still new with these git features.

The commit we want is here: 6f96747

git fetch upstream
git rebase upstream/master

Reports everything up to date

No worries. Our TVM website has one good Git usage tips: https://docs.tvm.ai/contribute/git_howto.html

[FrozenGene]

LGTM.

[tqchen]

Thanks @jmorrill @FrozenGene @soiferj !