Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTA] Removing dependences to NNVM #4419

Merged
merged 1 commit into from Nov 26, 2019
Merged

Conversation

tmoreau89
Copy link
Contributor

This PR removes all dependences to NNVM, and deletes deprecated libraries that relied upon analyzing NNVM graphs.

@liangfu
Copy link
Member

liangfu commented Nov 25, 2019

@tmoreau89 Thanks for deprecating nnvm in VTA.

Would you please also fix the following line error
https://github.com/apache/incubator-tvm/blob/dabde40f15423fc9632824dcd95696f36cf17a01/vta/tutorials/frontend/deploy_vision_on_vta.py#L173
, where relay.quantize.quantize is now defined to accept mod directly, see
https://github.com/apache/incubator-tvm/blob/dabde40f15423fc9632824dcd95696f36cf17a01/python/tvm/relay/quantize/quantize.py#L313-L322
for your reference.

@tmoreau89
Copy link
Contributor Author

@liangfu thank you for reporting the bug; I believe that #4295 has broken front end support in Relay for VTA. The issue is that this wasn't caught by the CI which should have re-built the VTA tutorials sphynx gallery. I'm following up to make sure that this doesn't happen in the future. I'll address your request in a separate PR.

@tqchen tqchen merged commit aab65ad into apache:master Nov 26, 2019
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Nov 26, 2019
yongwww pushed a commit to neo-ai/tvm that referenced this pull request Nov 26, 2019
@tmoreau89 tmoreau89 deleted the nnvm_del branch February 13, 2020 21:24
tqchen pushed a commit to tqchen/tvm that referenced this pull request Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants