Fix MSVC build error with container.h #4455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Dec 3, 2019
include/tvm/runtime/container.h
Outdated
| @@ -198,6 +198,7 @@ class ADTObj : public Object, public InplaceArrayBase<ADTObj, ObjectRef> { | |||
| } | |||
|
|
|||
| friend class ADT; | |||
| template <typename ArrayType, typename ElemType> | |||
There was a problem hiding this comment.
consider change to InplaceArrayBase<ADTObj, ObjectRef>
There was a problem hiding this comment.
Thanks! Changed it. This compiles clean here (VS 2019 toolset v14.2)
Closed
tqchen
approved these changes
Dec 3, 2019
tmoreau89
pushed a commit
to tmoreau89/tvm
that referenced
this pull request
Dec 3, 2019
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Dec 13, 2019
zxy844288792
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR 4346 introduced a breaking change in MSVC builds.
In container.h, 'non-class template has already been declared as a class template' on line 201.
This change fixes the builds on MSVC (2019 toolset v14.2), but have not tried on any other compiler.