Add __float2half_rn for cuda compute capabilities less than 53 #4489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhliu
approved these changes
Dec 10, 2019
|
Thanks @reminisce |
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Dec 13, 2019
zxy844288792
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When float32 consts are converted to float16,
__float2half_rn, which is officially defined incuda_fp16.hand included for cuda compute capabilities >= 53, is invoked. In this PR, the same function is added in cuda code gen for cuda compute capabilities < 53.Tested on sm_37 and sm_70.
Thank @yzhliu for pointers.