[NODE][Serialization]fix serialization precision loss in float #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we want to serialize a tvm.tensor object(like pickle)， we will get a precision loss cause by std::to_string()。
For example, a2.value will be 0.0 while a.value=0.00000001 in the following:
import tvm
import pickle
a = tvm.const(0.00000001, 'float32')
a2 = pickle.loads(pickle.dumps(a))
HisiFish
changed the title
HisiFish
changed the title
|
@junrushao1994 Hi, Shao, what should I do before this PR merged? It's the 1st time I start a pr to TVM. Not very clear to the rules. |
|
You should @ maintainers (aka committers how have permission to merge) on this thread. They will look at the patch and decide. Thanks! |
zxy844288792
pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Dec 13, 2019
…e#4503) * fix serialization precision loss in float When we want to serialize a tvm.tensor object(like pickle)， we will get a precision loss cause by std::to_string()。 For example, a2.value will be 0.0 while a.value=0.00000001 in the following: import tvm import pickle a = tvm.const(0.00000001, 'float32') a2 = pickle.loads(pickle.dumps(a)) * remove line end spaces
zxy844288792
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 13, 2019
…e#4503) * fix serialization precision loss in float When we want to serialize a tvm.tensor object(like pickle)， we will get a precision loss cause by std::to_string()。 For example, a2.value will be 0.0 while a.value=0.00000001 in the following: import tvm import pickle a = tvm.const(0.00000001, 'float32') a2 = pickle.loads(pickle.dumps(a)) * remove line end spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we want to serialize(such as pickle.dumps) a tvm.tensor object， we will get a precision loss caused by std::to_string()。
For example, a2.value will be 0.0 while a.value=0.00000001 in the following:
import tvm
import pickle
a = tvm.const(0.00000001, 'float32')
a2 = pickle.loads(pickle.dumps(a))
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.