Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX]Pool3d & upsample3d op support #5135

Merged
merged 4 commits into from Apr 4, 2020

Conversation

siju-samuel
Copy link
Member

Pool3d(fix) and upsample op for onnx frontend.
@FrozenGene @masahi @zhiics Please help to review and merge this PR.

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@zhiics
Copy link
Member

zhiics commented Mar 23, 2020

cc @cchung100m and @jwfromm as you guys have more experience on ONNX

Copy link
Contributor

@jwfromm jwfromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but overall looks pretty good. Thanks for the contribution!

python/tvm/relay/frontend/onnx.py Outdated Show resolved Hide resolved
python/tvm/relay/frontend/onnx.py Outdated Show resolved Hide resolved
tests/python/frontend/onnx/test_forward.py Outdated Show resolved Hide resolved
tests/python/frontend/onnx/test_forward.py Outdated Show resolved Hide resolved
Copy link
Contributor

@cchung100m cchung100m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @siju-samuel

@masahi masahi merged commit fd9ce58 into apache:master Apr 4, 2020
@masahi
Copy link
Member

masahi commented Apr 4, 2020

Thanks @siju-samuel @jwfromm @cchung100m

zhiics pushed a commit to comaniac/tvm that referenced this pull request Apr 7, 2020
* [ONNX]Pool3d and Upsample3d op updated

* Pool3d and Upsample3d testcase

* Review comments fixed

* Review comments
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
* [ONNX]Pool3d and Upsample3d op updated

* Pool3d and Upsample3d testcase

* Review comments fixed

* Review comments
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
* [ONNX]Pool3d and Upsample3d op updated

* Pool3d and Upsample3d testcase

* Review comments fixed

* Review comments
dpankratz pushed a commit to dpankratz/incubator-tvm that referenced this pull request Apr 24, 2020
* [ONNX]Pool3d and Upsample3d op updated

* Pool3d and Upsample3d testcase

* Review comments fixed

* Review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants