Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR][IR] kExternalSymbol -> kGlobalSymbol #5211

Merged
merged 2 commits into from Apr 2, 2020
Merged

[REFACTOR][IR] kExternalSymbol -> kGlobalSymbol #5211

merged 2 commits into from Apr 2, 2020

Conversation

zhiics
Copy link
Member

@zhiics zhiics commented Apr 2, 2020 •
edited

#5210

This PR replaces KExternalSymbol with kGlobalSymbol. The global_symbol is attached to functions for runtime symbol lookup.

@zhiics
Copy link
Member Author

zhiics commented Apr 2, 2020

cc @tqchen @comaniac

Maybe I should create a separate PR for the String object so that we can track it more conveniently?

comaniac
comaniac approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the external codegen part.

@zhiics zhiics mentioned this pull request Apr 2, 2020
Merged
@tqchen tqchen merged commit d2f9af7 into apache:master Apr 2, 2020
@zhiics zhiics deleted the symbol branch April 2, 2020 21:51
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
@zhiics
[REFACTOR][IR] kExternalSymbol -> kGlobalSymbol (apache#5211)
5b39e46 
* expose runtime::String to Python

* kExternalSymbol -> kGlobalSymbol
zhiics added a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
@zhiics
[REFACTOR][IR] kExternalSymbol -> kGlobalSymbol (apache#5211)
b52cc0c 
* expose runtime::String to Python

* kExternalSymbol -> kGlobalSymbol
@ZihengJiang ZihengJiang mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tqchen tqchen tqchen approved these changes

@comaniac comaniac comaniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhiics @tqchen @comaniac