Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay][Vm] Some performance improvement to VM #5901

Merged
merged 6 commits into from Jun 25, 2020

Conversation

icemelon
Copy link
Member

Some empirical performance improvement to Relay VM, including

  • Make alignment in AllocStorage constant
  • Use CopyTo instead of NDArray.CopyTo to avoid unnecessary memcpy

@icemelon icemelon requested review from jroesch and zhiics and removed request for jroesch June 23, 2020 18:20
switch (array->dtype.bits) {
case 1: {
result = reinterpret_cast<bool*>(array->data)[0];
LOG(INFO) << result;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@zhiics
Copy link
Member

zhiics commented Jun 24, 2020

@icemelon9 please fix the serialization of AllocStorage

@zhiics zhiics merged commit 7830561 into apache:master Jun 25, 2020
@zhiics
Copy link
Member

zhiics commented Jun 25, 2020

Thanks @icemelon9

@icemelon icemelon deleted the vm-improve branch June 25, 2020 19:11
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 30, 2020
* make alignment constant

* tweak copyto and loadscalarint

* some safety check

* x

* lint

* fix
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
* make alignment constant

* tweak copyto and loadscalarint

* some safety check

* x

* lint

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants