Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF Frontend]raise right error in tensorflow split op #5951

Merged
merged 1 commit into from Jun 28, 2020
Merged

[TF Frontend]raise right error in tensorflow split op #5951

merged 1 commit into from Jun 28, 2020

Conversation

Meteorix
Copy link
Contributor

when there are dynamic args in split op, it will raise AttributeError: <class ‘tvm.relay.expr.Call’> has no attribute name_hint. catch it and raise the correct error for better readability.

@siju-samuel could you help review this pr?

Copy link
Member

@siju-samuel siju-samuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tqchen tqchen merged commit 2b3d90a into apache:master Jun 28, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 30, 2020
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants