Raise an exception when extern function does not return Stmt #5964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function for tvm.te.extern should return either PrimExpr or Stmt, however there is no check if it actually does so. If it does not, the result may be a segmentation fault later on. Catch this case early on, so an informative message can be shown.
tqchen
approved these changes
Jun 30, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 30, 2020
…5964) The function for tvm.te.extern should return either PrimExpr or Stmt, however there is no check if it actually does so. If it does not, the result may be a segmentation fault later on. Catch this case early on, so an informative message can be shown.
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jul 2, 2020
…5964) The function for tvm.te.extern should return either PrimExpr or Stmt, however there is no check if it actually does so. If it does not, the result may be a segmentation fault later on. Catch this case early on, so an informative message can be shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function for
tvm.te.externshould return eitherPrimExprorStmt, however there is no check if it actually does so. If it does not, the result may be a segmentation fault later on. Catch this case early on, so an informative message can be shown.