[Relay][TF][BugFix] when converting constant nodes with types of int64 or float64 #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthesun
reviewed
Jul 29, 2020
| @@ -2835,7 +2835,7 @@ def _parse_param(self, key, value, name, shape): | |||
|
|
|||
| array_ndim = len(np_array.shape) | |||
| if array_ndim == 0: | |||
| self._nodes[name] = [tvm.relay.const(np_array)] | |||
| self._nodes[name] = [tvm.relay.const(np_array, np_array.dtype)] | |||
There was a problem hiding this comment.
Do we also need to fix non-scalar case？
There was a problem hiding this comment.
For non-scalar cases, it goes to self._params[name] = tvm.nd.array(np_array).
Seems the tvm.nd.array function doesn't have a default dtype, it always gets dtype from np_array. While tvm.relay.const has a default param dtype set to None.
|
Thanks @sleepwalker2017 |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…apache#6159) Co-authored-by: yuweilong <yuweilong03@meituan.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…apache#6159) Co-authored-by: yuweilong <yuweilong03@meituan.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Aug 26, 2020
…apache#6159) Co-authored-by: yuweilong <yuweilong03@meituan.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 2, 2020
…apache#6159) Co-authored-by: yuweilong <yuweilong03@meituan.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 3, 2020
…apache#6159) Co-authored-by: yuweilong <yuweilong03@meituan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when creating a constant node in relay, if dtype is not specified, inputs with int64 type will be converted to int32 type, which may cause error in following data type checks.