Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL integration bugfix: "verify" call parameter name changed #6382

Merged
merged 1 commit into from Sep 8, 2020
Merged

ACL integration bugfix: "verify" call parameter name changed #6382

merged 1 commit into from Sep 8, 2020

Conversation

d-smirnov
Copy link
Contributor

This PR fixes typo in ACL integration unit test

zhiics
zhiics reviewed Sep 2, 2020
View reviewed changes
Copy link
Member

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @lhutton1
does this mean these tests are never executed in the ci?

lhutton1
lhutton1 approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@lhutton1 lhutton1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, I was away all last week. Yep that's correct, they're run-time tests that require ACL so won't currently be run by CI. Looks like this was missed rebasing the fully connected patch.

@zhiics zhiics merged commit 9f2a90b into apache:master Sep 8, 2020
@zhiics
Copy link
Member

zhiics commented Sep 8, 2020

Thanks @d-smirnov @lhutton1

kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 17, 2020
@d-smirnov @kevinthesun
bugfix: "verify" call parameter name changed (apache#6382)
dd936fb
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 18, 2020
@d-smirnov @kevinthesun
bugfix: "verify" call parameter name changed (apache#6382)
dbd4df9
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 18, 2020
@d-smirnov @trevor-m
bugfix: "verify" call parameter name changed (apache#6382)
8506143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiics zhiics zhiics approved these changes

@lhutton1 lhutton1 lhutton1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d-smirnov @zhiics @lhutton1