Add safe up/downcasting to the Rust object system #6384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robo-corg
reviewed
Sep 2, 2020
jroesch
approved these changes
Sep 4, 2020
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
* Revamp the rust object system with safe subtyping * Small nits
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
* Revamp the rust object system with safe subtyping * Small nits
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
* Revamp the rust object system with safe subtyping * Small nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a clean up pass over the TVM object system in the Rust bindings. There are still some things to improve, but I think this is worth landing on its own.
The upshot is now any
IsObjectRefhas a safe, typecheckedupcastmethod to anything it inherits from.downcastis also typechecked, in that you may only attempt a downcast to from T to U if U is a subclass of T. There are some other minor cleanups in the Object derive-macro as well.@jroesch