[Rust] Improve the error reporting in build.rs files by using anyhow. #6401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
force-pushed
the
improve-build-rs
branch
from
4ec652d
to
b2ee000
Compare
adelbertc
approved these changes
Sep 4, 2020
imalsogreg
reviewed
Sep 9, 2020
imalsogreg
reviewed
Sep 9, 2020
imalsogreg
reviewed
Sep 9, 2020
Instead of just unwrapping use Result on main function, and use anyhow to add error context.
Co-authored-by: Greg Hale <ImAlsoGreg@gmail.com>
jroesch
force-pushed
the
improve-build-rs
branch
from
ba4a673
to
59eef19
Compare
tqchen
approved these changes
Sep 10, 2020
|
Thanks @imalsogreg @adelbertc @jroesch ! |
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
…apache#6401) * Improve build.rs error handling. Instead of just unwrapping use Result on main function, and use anyhow to add error context. * Remove NDArray and Python changes * Format * Fix build.rs * Apply suggestions from code review Co-authored-by: Greg Hale <ImAlsoGreg@gmail.com> * Format * Fix build.rs Co-authored-by: Greg Hale <ImAlsoGreg@gmail.com>
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
…apache#6401) * Improve build.rs error handling. Instead of just unwrapping use Result on main function, and use anyhow to add error context. * Remove NDArray and Python changes * Format * Fix build.rs * Apply suggestions from code review Co-authored-by: Greg Hale <ImAlsoGreg@gmail.com> * Format * Fix build.rs Co-authored-by: Greg Hale <ImAlsoGreg@gmail.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
…apache#6401) * Improve build.rs error handling. Instead of just unwrapping use Result on main function, and use anyhow to add error context. * Remove NDArray and Python changes * Format * Fix build.rs * Apply suggestions from code review Co-authored-by: Greg Hale <ImAlsoGreg@gmail.com> * Format * Fix build.rs Co-authored-by: Greg Hale <ImAlsoGreg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves errors when build.rs scripts fail. cc @robo-corg, @mwillsey and @areusch