[RELAY][REFACTOR] Mix mode context analysis #6403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandron
reviewed
Sep 7, 2020
|
cc @mbrookhart @masahi @icemelon9 @jroesch |
masahi
approved these changes
Sep 8, 2020
|
I need this fix for a new PyTorch frontend test I'm working on, so merging now. Thanks @zhiics @mbrookhart @leandron |
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
* mix mode context analysis * add uses_gpu decorator for more tests * revert visit counter * relax visit limit * lint * bump visit limit to 19 * typo
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
* mix mode context analysis * add uses_gpu decorator for more tests * revert visit counter * relax visit limit * lint * bump visit limit to 19 * typo
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
* mix mode context analysis * add uses_gpu decorator for more tests * revert visit counter * relax visit limit * lint * bump visit limit to 19 * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discuss.tvm.apache.org/t/vm-an-error-from-context-analysis-pass/7818
This PR uses the MixModeVisitor to leverage its non-recursive visitor and memoization. We bumped the visit limit to allow high order functions to be visited multiple times which enables pytorch lstm tests. More powerful unification needs to be added for these functions.
In addition, the use_gpu decorator is added to many more unit tests.