Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QNN][Relay] Fixed bug in quantized conv2d. #6420

Merged
merged 1 commit into from Sep 10, 2020

Conversation

jainris
Copy link
Contributor

@jainris jainris commented Sep 8, 2020

  • Fixed bug in quantized conv2d where when kernel size = (1,1)
    and strides != (1,1) it would raise size mismatch error.
  • Added test to check qnn.conv2d with kernel size = (1,1) and
    strides != (1,1).

* Fixed bug in quantized conv2d where when kernel size = (1,1)
  and strides != (1,1) it would raise size mismatch error.
* Added test to check qnn.conv2d with kernel size = (1,1) and
  strides != (1,1).
@zhiics
Copy link
Member

zhiics commented Sep 8, 2020

cc @anijain2305 @shoubhik

@jainris
Copy link
Contributor Author

jainris commented Sep 9, 2020

cc @u99127 @mbaret @FrozenGene @tqchen

@anijain2305
Copy link
Contributor

Sorry for the delay. I will review it tomorrow.

Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Thanks for the changes.

@anijain2305 anijain2305 merged commit aeef16d into apache:master Sep 10, 2020
@anijain2305
Copy link
Contributor

Thanks @jainris This is merged!

kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 17, 2020
* Fixed bug in quantized conv2d where when kernel size = (1,1)
  and strides != (1,1) it would raise size mismatch error.
* Added test to check qnn.conv2d with kernel size = (1,1) and
  strides != (1,1).
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 18, 2020
* Fixed bug in quantized conv2d where when kernel size = (1,1)
  and strides != (1,1) it would raise size mismatch error.
* Added test to check qnn.conv2d with kernel size = (1,1) and
  strides != (1,1).
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 18, 2020
* Fixed bug in quantized conv2d where when kernel size = (1,1)
  and strides != (1,1) it would raise size mismatch error.
* Added test to check qnn.conv2d with kernel size = (1,1) and
  strides != (1,1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants