[BUG][ConvertLayout] Fix qnn.conv2d layout conversion too many values to unpack #6442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhutton1
force-pushed
the
fix-too-many-values
branch
from
0e8261d
to
bb4cb09
Compare
anijain2305
approved these changes
Sep 10, 2020
|
please wait until we merge #6448 first. |
… to unpack This patch follows a previous bugfix in apache#6419. I made a very simple oversight for qnn.conv2d in that tinfos also contains qnn parameters. Therefore, we need to extract data_info and weight_info differently. Change-Id: Ib0ad01f427543371380d0bb604a77b5e0ec1103d
lhutton1
force-pushed
the
fix-too-many-values
branch
from
bb4cb09
to
8dacecf
Compare
|
Thanks @lhutton1 @anijain2305 @comaniac @leandron |
lhutton1
added a commit
to lhutton1/tvm
that referenced
this pull request
Sep 16, 2020
After apache#6442 was merged, black started complaining about formatting of test_pass_convert_op_layout.py. Format here. Change-Id: I04346fa06e22b722b619488b895b47c6943e3fd9
masahi
pushed a commit
that referenced
this pull request
Sep 16, 2020
After #6442 was merged, black started complaining about formatting of test_pass_convert_op_layout.py. Format here. Change-Id: I04346fa06e22b722b619488b895b47c6943e3fd9
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
… to unpack (apache#6442) This patch follows a previous bugfix in apache#6419. I made a very simple oversight for qnn.conv2d in that tinfos also contains qnn parameters. Therefore, we need to extract data_info and weight_info differently. Change-Id: Ib0ad01f427543371380d0bb604a77b5e0ec1103d
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
After apache#6442 was merged, black started complaining about formatting of test_pass_convert_op_layout.py. Format here. Change-Id: I04346fa06e22b722b619488b895b47c6943e3fd9
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
… to unpack (apache#6442) This patch follows a previous bugfix in apache#6419. I made a very simple oversight for qnn.conv2d in that tinfos also contains qnn parameters. Therefore, we need to extract data_info and weight_info differently. Change-Id: Ib0ad01f427543371380d0bb604a77b5e0ec1103d
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
After apache#6442 was merged, black started complaining about formatting of test_pass_convert_op_layout.py. Format here. Change-Id: I04346fa06e22b722b619488b895b47c6943e3fd9
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
… to unpack (apache#6442) This patch follows a previous bugfix in apache#6419. I made a very simple oversight for qnn.conv2d in that tinfos also contains qnn parameters. Therefore, we need to extract data_info and weight_info differently. Change-Id: Ib0ad01f427543371380d0bb604a77b5e0ec1103d
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
After apache#6442 was merged, black started complaining about formatting of test_pass_convert_op_layout.py. Format here. Change-Id: I04346fa06e22b722b619488b895b47c6943e3fd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch follows a previous bugfix in #6419. I made a very simple oversight for qnn.conv2d in that tinfos also contains qnn parameters. Therefore, we need to extract data_info and weight_info differently.
cc @leandron @anijain2305 @JoeyTPChou