New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Add support for GatherElements conversion #6446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just remove the prints
f94b408
to
6cac63b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@siju-samuel please don't merge this PR until we first let #6448 in (I was asked by Jared to merge that PR as soon as possible before any other PR, to avoid conflict) |
6cac63b
to
f744383
Compare
f744383
to
459adfa
Compare
@tqchen I've got "no space left on device" from CI. Is CI having a problem? |
459adfa
to
c76317e
Compare
I got the same error on another PR |
@masahi @mbrookhart please retrigger, the space issue has been resolved |
c76317e
to
37fb5c4
Compare
Thanks @siju-samuel @mbrookhart |
* support onnx GatherElements * remove print * run black Co-authored-by: masa <masa@pop-os.localdomain>
* support onnx GatherElements * remove print * run black Co-authored-by: masa <masa@pop-os.localdomain>
* support onnx GatherElements * remove print * run black Co-authored-by: masa <masa@pop-os.localdomain>
https://github.com/onnx/onnx/blob/master/docs/Operators.md#GatherElements
This is required to convert decision trees from hummingbird to Relay.
please review @siju-samuel @jwfromm @mbrookhart