ROCm: use GcnArch for mcpu and ApiVersion to select code object version #6447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see. So there are actually two version, one is ApiVersion, which is used to decide whether to add "-code-object-v3" into mattr; Another is GcnArch, which is used to decode "mcpu". Thank you for the clarification! |
tqchen
approved these changes
Sep 10, 2020
|
@junrushao1994 Yeah, and I'll admit that I wouldn't have spotted it without trying to run it on the hardware that is particular about it... |
masahi
approved these changes
Sep 11, 2020
|
Thanks @t-vi @junrushao1994 @tqchen |
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 17, 2020
kevinthesun
pushed a commit
to kevinthesun/tvm
that referenced
this pull request
Sep 18, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a ROCm followup for #6347 bringing the code that was moved from src/target/llvm/codegen_amdgpu.cc to src/target/target_kind.cc closer to the old mechanism for compute arch autodetection.
@junrushao1994 @masahi