[RELAY][ConvertLayout] Make missing desired layout non-fatal #6553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anijain2305 Could you please review? Thanks! |
anijain2305
approved these changes
Sep 24, 2020
comaniac
approved these changes
Sep 24, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 25, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 25, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Sep 28, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ConvertLayout encounters an operator which is supported by ConvertLayout but a desired_layout is not provided by the user, it will create a fatal error. With this PR, it will instead just give a warning and leave that operator how it was.
Currently, anytime a new operator is added to ConvertLayout, it will break ConvertLayout for anyone using it in their code. For example, a BYOC target may want all Conv2D ops to be converted to NCHW but doesn't care about the layout of other ops. They shouldn't have to specify a desired layout for every single op which is supported by ConvertLayout, only the ones which they care about.