Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tvmc][docs] Getting started tutorial for TVMC #6597

Merged
merged 4 commits into from Oct 2, 2020
Merged

[tvmc][docs] Getting started tutorial for TVMC #6597

merged 4 commits into from Oct 2, 2020

Conversation

leandron
Copy link
Contributor

Introduces a tutorial about TVMC, including a full pipeline tvmc tune, tvmc compile, tvmc run, with a working example using ResNet-50. The tutorial assumes #6578 as part of tvmc, so in case you want to try it out, please apply that PR locally.

cc @comaniac @FrozenGene @u99127 for review if possible

@leandron leandron mentioned this pull request Sep 30, 2020
Closed
@leandron @mbaret
[tvmc][docs] Getting started tutorial for TVMC
019ef3f 
 * Include a tutorial, demonstrating basic capabilities of
   TVMC, by executing a full pipeline (tune, compile, run)
   on a ResNet-50 model.


Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>
@comaniac comaniac self-assigned this Sep 30, 2020
comaniac
comaniac requested changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!
Also cc @masahi @tmoreau89 @tqchen

tutorials/get_started/tvmc_command_line_driver.py Outdated Show resolved Hide resolved
tutorials/get_started/tvmc_command_line_driver.py Outdated Show resolved Hide resolved
tutorials/get_started/tvmc_command_line_driver.py Outdated Show resolved Hide resolved
tutorials/get_started/tvmc_command_line_driver.py Show resolved Hide resolved
tutorials/get_started/tvmc_command_line_driver.py Outdated Show resolved Hide resolved
tutorials/get_started/tvmc_command_line_driver.py Outdated Show resolved Hide resolved
tutorials/get_started/tvmc_command_line_driver.py Outdated Show resolved Hide resolved
tutorials/get_started/tvmc_command_line_driver.py Outdated Show resolved Hide resolved
tutorials/get_started/tvmc_command_line_driver.py Show resolved Hide resolved
leandron and others added 2 commits October 1, 2020 14:18
@leandron @tkonolige @comaniac
apply suggestions from code review
3410863 
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
@leandron
adjust text according to code-review
7541474
comaniac
comaniac approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just a final comment.
@tmoreau89 @tqchen would you mind taking a look before we merge it?

tutorials/get_started/tvmc_command_line_driver.py Show resolved Hide resolved
@ZihengJiang ZihengJiang mentioned this pull request Oct 2, 2020
Closed
tmoreau89
tmoreau89 approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @leandron @mbaret , the tutorial reads well.

@comaniac comaniac merged commit 9f5b9da into apache:master Oct 2, 2020
@comaniac
Copy link
Contributor

comaniac commented Oct 2, 2020

Thanks @leandron @mbaret @tkonolige @tqchen @tmoreau89

@leandron leandron deleted the tvmc_tutorial branch October 2, 2020 07:03
@hogepodge
Copy link
Contributor

I can start a discuss forum topic on this if you think it's better, but I'm running into trouble running TVMC. I'm trying to import the resnet50-v2.7 model for tuning, and it's throwing a 'The function of this task is not found. Possibly the function of this task is registered in another python file which is not imported in this run' error. Am I missing a dependency, or is something else going on?

@comaniac
Copy link
Contributor

comaniac commented Oct 3, 2020

Yes please open a topic at the discuss forum.

TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 13, 2020
@leandron @mbaret
@tkonolige @comaniac
[tvmc][docs] Getting started tutorial for TVMC (apache#6597)
27723e0 
* [tvmc][docs] Getting started tutorial for TVMC

 * Include a tutorial, demonstrating basic capabilities of
   TVMC, by executing a full pipeline (tune, compile, run)
   on a ResNet-50 model.


Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>

* apply suggestions from code review

Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>

* adjust text according to code-review

* improve reading flow into tuning section

Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 14, 2020
@leandron @mbaret
@tkonolige @comaniac
[tvmc][docs] Getting started tutorial for TVMC (apache#6597)
8fa0ba2 
* [tvmc][docs] Getting started tutorial for TVMC

 * Include a tutorial, demonstrating basic capabilities of
   TVMC, by executing a full pipeline (tune, compile, run)
   on a ResNet-50 model.


Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>

* apply suggestions from code review

Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>

* adjust text according to code-review

* improve reading flow into tuning section

Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 15, 2020
@leandron @mbaret
@tkonolige @comaniac
[tvmc][docs] Getting started tutorial for TVMC (apache#6597)
d241781 
* [tvmc][docs] Getting started tutorial for TVMC

 * Include a tutorial, demonstrating basic capabilities of
   TVMC, by executing a full pipeline (tune, compile, run)
   on a ResNet-50 model.


Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>

* apply suggestions from code review

Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>

* adjust text according to code-review

* improve reading flow into tuning section

Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Oct 16, 2020
@leandron @mbaret
@tkonolige @comaniac
[tvmc][docs] Getting started tutorial for TVMC (apache#6597)
3a96ed0 
* [tvmc][docs] Getting started tutorial for TVMC

 * Include a tutorial, demonstrating basic capabilities of
   TVMC, by executing a full pipeline (tune, compile, run)
   on a ResNet-50 model.


Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>

* apply suggestions from code review

Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>

* adjust text according to code-review

* improve reading flow into tuning section

Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Oct 19, 2020
@leandron @mbaret
@tkonolige @comaniac @trevor-m
[tvmc][docs] Getting started tutorial for TVMC (apache#6597)
b8dccf2 
* [tvmc][docs] Getting started tutorial for TVMC

 * Include a tutorial, demonstrating basic capabilities of
   TVMC, by executing a full pipeline (tune, compile, run)
   on a ResNet-50 model.


Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>

* apply suggestions from code review

Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>

* adjust text according to code-review

* improve reading flow into tuning section

Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkonolige tkonolige tkonolige left review comments

@comaniac comaniac comaniac approved these changes

@tqchen tqchen tqchen approved these changes

@tmoreau89 tmoreau89 tmoreau89 approved these changes

Assignees

@comaniac comaniac

Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@leandron @comaniac @hogepodge @tkonolige @tqchen @tmoreau89