[BUG_FIX] Fixes #6608: CHECK(data != nullptr) causes type checking to fail #6610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
requested changes
Oct 1, 2020
src/relay/op/tensor/transform.cc
Outdated
| @@ -1979,7 +1985,11 @@ bool StridedSliceRel(const Array<Type>& types, int num_inputs, const Attrs& attr | |||
| const StridedSliceAttrs* param = attrs.as<StridedSliceAttrs>(); | |||
| CHECK(param != nullptr); | |||
| const auto* data = types[0].as<TensorTypeNode>(); | |||
| CHECK(data != nullptr); | |||
|
|
|||
| if (data != nullptr) { | |||
There was a problem hiding this comment.
Should be fixed now.
mbrookhart
approved these changes
Oct 1, 2020
vegaluisjose
approved these changes
Oct 1, 2020
|
Thanks @electriclilies @vegaluisjose @mbrookhart ! |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 13, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 14, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 16, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some type rels check that argument types are not null. In certain cases, this can cause the type inferencer to exit prematurely, and the model cannot be run.
Instead of checking that argument types are not null, type rels should just return false, and allow the type checker to determine if the type of arguments cannot be inferred.
I believe this PR fixes all of the type rels with this issue, however I could have missed some. If you find another, please let me know.
See issue #6608 for more details.
cc @jwfromm @vegaluisjose @areusch @mbrookhart