Fix a bug with Alter Op Layout #6626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmoreau89
approved these changes
Oct 5, 2020
|
Thank you @mbrookhart @jwfromm the PR has been merged. |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 13, 2020
* Regression test for a Scalar type issue in Alter Op Layout * fix the regression test by avoiding the Scalar optimization if types aren't defined
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 14, 2020
* Regression test for a Scalar type issue in Alter Op Layout * fix the regression test by avoiding the Scalar optimization if types aren't defined
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
* Regression test for a Scalar type issue in Alter Op Layout * fix the regression test by avoiding the Scalar optimization if types aren't defined
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 16, 2020
* Regression test for a Scalar type issue in Alter Op Layout * fix the regression test by avoiding the Scalar optimization if types aren't defined
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 19, 2020
* Regression test for a Scalar type issue in Alter Op Layout * fix the regression test by avoiding the Scalar optimization if types aren't defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a case where models imported from Tensorflow in NHWC layout fail in AlterOpLayout due to an odd combination of passes. This PR adds a regression tests and short-circuits the Scalar optimization to fix the bug.
Tagging @anijain2305 becuase you originally added the Scalar check in Alter Op Layout. You can see the bug if you remove my changes to that check, I don't see a cleaner fix at the moment.
cc @jwfromm @tmoreau89