[TEST][TEDD] improve TEDD tests to also run on CPU Docker image #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongfeng-nv
approved these changes
Oct 7, 2020
|
Retriggering, due to some CI crash at build time, not related to this PR |
|
Also cc @zhiics @FrozenGene for reviews and merge if you are happy with this change |
zhiics
reviewed
Oct 8, 2020
* Amend regular expressions to match with what is being reported by CPU Docker image Graphviz * Fix typo on dependency checking function * Organise imports
|
Once this is merged, I'd consider it closes #6642. |
zhiics
approved these changes
Oct 8, 2020
|
If possible, can we merge this? Just asking, so that I can fix my own CI. |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 13, 2020
…che#6643) * Amend regular expressions to match with what is being reported by CPU Docker image Graphviz * Fix typo on dependency checking function * Organise imports
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 14, 2020
…che#6643) * Amend regular expressions to match with what is being reported by CPU Docker image Graphviz * Fix typo on dependency checking function * Organise imports
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 15, 2020
…che#6643) * Amend regular expressions to match with what is being reported by CPU Docker image Graphviz * Fix typo on dependency checking function * Organise imports
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Oct 16, 2020
…che#6643) * Amend regular expressions to match with what is being reported by CPU Docker image Graphviz * Fix typo on dependency checking function * Organise imports
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 19, 2020
…che#6643) * Amend regular expressions to match with what is being reported by CPU Docker image Graphviz * Fix typo on dependency checking function * Organise imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves TEDD testing, so that is can run on
ci-cpuDocker image. It currently fails if you try to run it on aci-cpuimage that hasgraphvizinstalled. The test currently shows as "passing" in CI, but checks are not actually done.We still need to have a separate PR to install graphviz on
ci-cpu, to make this test to actually do something. In this PR, we only will be able to obeserve that it doesn't break the current setup. Reported on #6642 (more context there).cc @yongfeng-nv @tqchen for reviews.