Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenCL] Only use thrust for cuda targets #6722

Merged
merged 1 commit into from Oct 29, 2020

Conversation

trevor-m
Copy link
Contributor

@trevor-m trevor-m commented Oct 20, 2020

Thrust is not available for OpenCL, but TVM will still try to use it for opencl targets in addition to cuda targets. This would result in a runtime error on an OpenCL device which doesn't have thrust.

@trevor-m
Copy link
Contributor Author

@Laurawly @kazum @masahi Could you please help review? Thanks!

Copy link
Contributor

@Laurawly Laurawly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the cases for OpenCL

@Laurawly Laurawly merged commit b305204 into apache:main Oct 29, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants