New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add m6g instance (ARM64) to CI #6781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! It looks like a good improvement for our upstream CI.
A few comments based on some experiments I did in that direction, in past.
COPY install/ubuntu_install_llvm.sh /install/ubuntu_install_llvm.sh | ||
RUN bash /install/ubuntu_install_llvm.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script uses apt.llvm.org
repository, which does not publish AArch64 (arm64) builds. So, if you want to use the same LLVM versions we have for other builds, for now, one option would be downloading and uncompressing an LLVM build from the official source:
- LLVM 11: https://github.com/llvm/llvm-project/releases/download/llvmorg-11.0.0/clang+llvm-11.0.0-aarch64-linux-gnu.tar.xz
- LLVM 10: https://github.com/llvm/llvm-project/releases/download/llvmorg-10.0.0/clang+llvm-10.0.0-aarch64-linux-gnu.tar.xz
- LLVM 9: https://releases.llvm.org/9.0.0/clang+llvm-9.0.0-aarch64-linux-gnu.tar.xz
Once arm64 builds are published into apt.llvm.org, then we can just share the same existing scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current one is more like experimental. I did test it locally. It seems every was okay. I will probably leave these arm specific installation (including acl etc) to your folks, how do you think?
docker/Dockerfile.ci_arm
Outdated
RUN apt-get update --fix-missing | ||
RUN apt-get install -y ca-certificates | ||
RUN apt-get install -y gnupg2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is likely to increase the space taken by the resultant Docker image. It is recommended (by Docker) to line-up apt-get calls in one statement, and make sure you remove the apt cache by the end.
* [CI] Add m6g instance (ARM64) to CI * address comments Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal>
* [CI] Add m6g instance (ARM64) to CI (#6781) * [CI] Add m6g instance (ARM64) to CI * address comments Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal> * [CI] fix cpp test (#6796) * Update tests/python/unittest/test_target_codegen_x86.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal> Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
* [CI] Add m6g instance (ARM64) to CI (apache#6781) * [CI] Add m6g instance (ARM64) to CI * address comments Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal> * [CI] fix cpp test (apache#6796) * Update tests/python/unittest/test_target_codegen_x86.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal> Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
* [CI] Add m6g instance (ARM64) to CI (apache#6781) * [CI] Add m6g instance (ARM64) to CI * address comments Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal> * [CI] fix cpp test (apache#6796) * Update tests/python/unittest/test_target_codegen_x86.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal> Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
* [CI] Add m6g instance (ARM64) to CI (apache#6781) * [CI] Add m6g instance (ARM64) to CI * address comments Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal> * [CI] fix cpp test (apache#6796) * Update tests/python/unittest/test_target_codegen_x86.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal> Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com> Co-authored-by: Cody Yu <comaniac0422@gmail.com>
No description provided.