Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add m6g instance (ARM64) to CI #6781

Merged
merged 2 commits into from Oct 28, 2020
Merged

Conversation

zhiics
Copy link
Member

@zhiics zhiics commented Oct 28, 2020

No description provided.

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! It looks like a good improvement for our upstream CI.

A few comments based on some experiments I did in that direction, in past.

Comment on lines +30 to +31
COPY install/ubuntu_install_llvm.sh /install/ubuntu_install_llvm.sh
RUN bash /install/ubuntu_install_llvm.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script uses apt.llvm.org repository, which does not publish AArch64 (arm64) builds. So, if you want to use the same LLVM versions we have for other builds, for now, one option would be downloading and uncompressing an LLVM build from the official source:

Once arm64 builds are published into apt.llvm.org, then we can just share the same existing scripts.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current one is more like experimental. I did test it locally. It seems every was okay. I will probably leave these arm specific installation (including acl etc) to your folks, how do you think?

docker/Dockerfile.ci_arm Outdated Show resolved Hide resolved
Comment on lines 23 to 25
RUN apt-get update --fix-missing
RUN apt-get install -y ca-certificates
RUN apt-get install -y gnupg2
Copy link
Contributor

@leandron leandron Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is likely to increase the space taken by the resultant Docker image. It is recommended (by Docker) to line-up apt-get calls in one statement, and make sure you remove the apt cache by the end.

@zhiics zhiics merged commit 19b4fc3 into apache:ci-docker-staging Oct 28, 2020
@zhiics zhiics deleted the ci branch October 29, 2020 23:48
zhiics added a commit to zhiics/tvm that referenced this pull request Oct 30, 2020
* [CI] Add m6g instance (ARM64) to CI

* address comments

Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal>
tqchen added a commit that referenced this pull request Oct 31, 2020
* [CI] Add m6g instance (ARM64) to CI (#6781)

* [CI] Add m6g instance (ARM64) to CI

* address comments

Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal>

* [CI] fix cpp test (#6796)

* Update tests/python/unittest/test_target_codegen_x86.py

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal>
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
* [CI] Add m6g instance (ARM64) to CI (apache#6781)

* [CI] Add m6g instance (ARM64) to CI

* address comments

Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal>

* [CI] fix cpp test (apache#6796)

* Update tests/python/unittest/test_target_codegen_x86.py

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal>
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
* [CI] Add m6g instance (ARM64) to CI (apache#6781)

* [CI] Add m6g instance (ARM64) to CI

* address comments

Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal>

* [CI] fix cpp test (apache#6796)

* Update tests/python/unittest/test_target_codegen_x86.py

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal>
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
* [CI] Add m6g instance (ARM64) to CI (apache#6781)

* [CI] Add m6g instance (ARM64) to CI

* address comments

Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal>

* [CI] fix cpp test (apache#6796)

* Update tests/python/unittest/test_target_codegen_x86.py

Co-authored-by: Cody Yu <comaniac0422@gmail.com>

Co-authored-by: Ubuntu <ubuntu@ip-172-31-54-90.us-west-2.compute.internal>
Co-authored-by: Tianqi Chen <tqchen@users.noreply.github.com>
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants