Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

WeexSDK.podspec contains a part of headers #1399

Closed
mario-huang opened this issue Aug 7, 2018 · 4 comments
Closed

WeexSDK.podspec contains a part of headers #1399

mario-huang opened this issue Aug 7, 2018 · 4 comments

Comments

@mario-huang
Copy link
Contributor

I see the podspec in Specs is different from incubator-weex.
Specs has public_header_files, which is not enough to use for second dev.

@xuyouyang
Copy link
Contributor

@myeveryheart do you mean that any implements you need are not in the public_header_files yet? Can you describe it in more detail? Thanks.

@mario-huang
Copy link
Contributor Author

@xuyouyang Yes, you are right. Cocoapods can create public headers If no public headers are specified then all the headers in source_files are considered public. That would be better.

@xuyouyang
Copy link
Contributor

xuyouyang commented Aug 14, 2018

@myeveryheart I am sorry that I maybe not agree with you. In my opinions, a SDK framework do not need to public every file, such as some inner utility files. If you want to use or add more implements, you can add 'Category' files in your own project. Furthermore, you can import Weex source code to your project and public anything you want through local pod.

@mario-huang
Copy link
Contributor Author

@xuyouyang Ok, I get it, thx

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants